From 001c94865c98836b06c827ff890a5589dd97320d Mon Sep 17 00:00:00 2001
From: Nicolas Werner <nicolas.werner@hotmail.de>
Date: Tue, 12 Nov 2019 15:10:59 +0000
Subject: [PATCH] Fix windows build

No idea, why apply visitor doesn't work with temporaries?
---
 src/dialogs/RoomSettings.cpp         | 2 +-
 src/timeline/TimelineModel.cpp       | 8 +++++---
 src/timeline/TimelineViewManager.cpp | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/dialogs/RoomSettings.cpp b/src/dialogs/RoomSettings.cpp
index 00b034cc..25909cd8 100644
--- a/src/dialogs/RoomSettings.cpp
+++ b/src/dialogs/RoomSettings.cpp
@@ -488,7 +488,7 @@ RoomSettings::retrieveRoomInfo()
                 usesEncryption_ = cache::client()->isRoomEncrypted(room_id_.toStdString());
                 info_           = cache::client()->singleRoomInfo(room_id_.toStdString());
                 setAvatar();
-        } catch (const lmdb::error &e) {
+        } catch (const lmdb::error &) {
                 nhlog::db()->warn("failed to retrieve room info from cache: {}",
                                   room_id_.toStdString());
         }
diff --git a/src/timeline/TimelineModel.cpp b/src/timeline/TimelineModel.cpp
index 6b0057a4..39abbf6f 100644
--- a/src/timeline/TimelineModel.cpp
+++ b/src/timeline/TimelineModel.cpp
@@ -438,16 +438,17 @@ TimelineModel::data(const QModelIndex &index, int role) const
                   boost::apply_visitor([](const auto &e) -> QString { return senderId(e); }, event);
 
                 for (int r = index.row() - 1; r > 0; r--) {
+                        auto tempEv        = events.value(eventOrder[r]);
                         QDateTime prevDate = boost::apply_visitor(
                           [](const auto &e) -> QDateTime { return eventTimestamp(e); },
-                          events.value(eventOrder[r]));
+                          tempEv);
                         prevDate.setTime(QTime());
                         if (prevDate != date)
                                 return QString("%2 %1").arg(date.toMSecsSinceEpoch()).arg(userId);
 
                         QString prevUserId =
                           boost::apply_visitor([](const auto &e) -> QString { return senderId(e); },
-                                               events.value(eventOrder[r]));
+                                               tempEv);
                         if (userId != prevUserId)
                                 break;
                 }
@@ -1313,7 +1314,8 @@ TimelineModel::processOnePendingMessage()
 
         QString txn_id_qstr = pending.first();
 
-        boost::apply_visitor(SendMessageVisitor{txn_id_qstr, this}, events.value(txn_id_qstr));
+        auto event = events.value(txn_id_qstr);
+        boost::apply_visitor(SendMessageVisitor{txn_id_qstr, this}, event);
 }
 
 void
diff --git a/src/timeline/TimelineViewManager.cpp b/src/timeline/TimelineViewManager.cpp
index 06c42a39..39bdfcf4 100644
--- a/src/timeline/TimelineViewManager.cpp
+++ b/src/timeline/TimelineViewManager.cpp
@@ -200,7 +200,7 @@ TimelineViewManager::saveMedia(QString mxcUrl,
                           if (!file.open(QIODevice::WriteOnly))
                                   return;
 
-                          file.write(QByteArray(data.data(), data.size()));
+                          file.write(QByteArray(data.data(), (int)data.size()));
                           file.close();
                   } catch (const std::exception &e) {
                           nhlog::ui()->warn("Error while saving file to: {}", e.what());