d3v1l/matrixion
1
0
Fork 0
mirror of https://github.com/Nheko-Reborn/nheko.git synced 2024-10-30 17:40:47 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prevent old verification requests from showing up

Browse source
This commit is contained in:
Nicolas Werner 2022-02-14 15:25:55 +01:00
parent 6e1ac16f61
commit 1bc986fd3b
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/encryption/VerificationManager.cpp
View file

@ -4,6 +4,9 @@
// SPDX-License-Identifier: GPL-3.0-or-later
#include "VerificationManager.h"
#include <chrono>
#include "Cache.h"
#include "ChatPage.h"
#include "DeviceVerificationFlow.h"
@ -14,6 +17,20 @@ VerificationManager::VerificationManager(TimelineViewManager *o)
, rooms_(o->rooms())
{}
static bool
isValidTime(std::optional<uint64_t> t)
{
if (!t)
return false;
using namespace std::chrono_literals;
std::chrono::time_point<std::chrono::system_clock> time{std::chrono::milliseconds(*t)};
auto diff = std::chrono::system_clock::now() - time;
return diff < 10min && diff > -5min;
}
void
VerificationManager::receivedRoomDeviceVerificationRequest(
const mtx::events::RoomEvent<mtx::events::msg::KeyVerificationRequest> &message,
@ -22,6 +39,9 @@ VerificationManager::receivedRoomDeviceVerificationRequest(
if (this->isInitialSync_)
return;
if (!isValidTime(message.origin_server_ts))
return;
auto event_id = QString::fromStdString(message.event_id);
if (!this->dvList.contains(event_id)) {
if (auto flow = DeviceVerificationFlow::NewInRoomVerification(
@ -40,6 +60,9 @@ VerificationManager::receivedDeviceVerificationRequest(
if (this->isInitialSync_)
return;
if (!isValidTime(msg.timestamp))
return;
if (!msg.transaction_id)
return;
@ -61,6 +84,10 @@ VerificationManager::receivedDeviceVerificationStart(
if (this->isInitialSync_)
return;
// can't do this for start messages sent as to_device...
// if (!isValidTime(msg.timestamp))
// return;
if (!msg.transaction_id)
return;