d3v1l/matrixion
1
0
Fork 0
mirror of https://github.com/Nheko-Reborn/nheko.git synced 2024-11-24 20:18:53 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix high CPU use caused by ItemParticle

Browse source
This commit is contained in:
Nicolas Werner 2023-10-09 03:48:58 +02:00
parent 2a687a202a
commit 25f19c11b1
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9
1 changed files with 35 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
resources/qml/ui/TimelineEffects.qml
View file

@ -9,6 +9,7 @@ Item {
id: effectRoot id: effectRoot
readonly property int maxLifespan: Math.max(confettiEmitter.lifeSpan, rainfallEmitter.lifeSpan) readonly property int maxLifespan: Math.max(confettiEmitter.lifeSpan, rainfallEmitter.lifeSpan)
required property bool shouldEffectsRun required property bool shouldEffectsRun
visible: effectRoot.shouldEffectsRun
function pulseConfetti() function pulseConfetti()
{ {
@ -25,11 +26,13 @@ Item {
Component.onCompleted: pause(); Component.onCompleted: pause();
paused: !effectRoot.shouldEffectsRun paused: !effectRoot.shouldEffectsRun
running: effectRoot.shouldEffectsRun
} }
Emitter { Emitter {
id: confettiEmitter id: confettiEmitter
Component.onCompleted: stop();
group: "confetti" group: "confetti"
width: effectRoot.width * 3/4 width: effectRoot.width * 3/4
enabled: false enabled: false
@ -89,26 +92,47 @@ Item {
enabled: false enabled: false
anchors.horizontalCenter: effectRoot.horizontalCenter anchors.horizontalCenter: effectRoot.horizontalCenter
y: -60 y: -60
emitRate: effectRoot.width / 50 emitRate: effectRoot.width / 30
lifeSpan: 10000 lifeSpan: 10000
system: particleSystem system: particleSystem
velocity: PointDirection { velocity: PointDirection {
x: 0 x: 0
y: 300 y: 400
xVariation: 0 xVariation: 0
yVariation: 75 yVariation: 75
} }
ItemParticle { // causes high CPU load, see: https://bugreports.qt.io/browse/QTBUG-117923
system: particleSystem //ItemParticle {
groups: ["rain"] // system: particleSystem
fade: false // groups: ["rain"]
delegate: Rectangle { // fade: false
width: 2 // visible: effectRoot.shouldEffectsRun
height: 30 + 30 * Math.random() // delegate: Rectangle {
radius: 2 // width: 2
// height: 30 + 30 * Math.random()
// radius: 2
// color: "#0099ff"
// }
//}
ImageParticle {
system: particleSystem
groups: ["rain"]
source: "qrc:/confettiparticle.svg"
rotationVelocity: 0
rotationVelocityVariation: 0
colorVariation: 0
color: "#0099ff" color: "#0099ff"
entryEffect: ImageParticle.None
xVector: PointDirection {
x: 0.01
y: 0
}
yVector: PointDirection {
x: 0
y: 5
}
} }
} }
} }
}