d3v1l/matrixion
1
0
Fork 0
mirror of https://github.com/Nheko-Reborn/nheko.git synced 2024-10-30 09:30:47 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use dynamic properties for NhekoFixupPaletteEventFilter

Browse source 
A new window could have the same `QWindow *` value as an already free'ed window,
so using a `QSet<QWindow *>` with potentially free'ed windows might not be reliable.
Use dynamic properties instead.
This commit is contained in:
q234rty 2023-12-29 14:51:37 +08:00
parent fa53b5b5f3
commit 2ced20d755
No known key found for this signature in database
GPG key ID: D7E83C63C8CC4545
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/MainWindow.cpp
View file

@ -201,14 +201,12 @@ NhekoFixupPaletteEventFilter::eventFilter(QObject *obj, QEvent *event)
// reason?!?
if (event->type() == QEvent::ChildAdded &&
obj->metaObject()->className() == QStringLiteral("QQuickRootItem")) {
QSet<QWindow *> newWindows;
for (const auto window : QGuiApplication::topLevelWindows()) {
newWindows.insert(window);
if (m_postedWindows.contains(window))
if (window->property("posted").isValid())
continue;
QGuiApplication::postEvent(window, new QEvent(QEvent::ApplicationPaletteChange));
window->setProperty("posted", true);
}
m_postedWindows.swap(newWindows);
}
return false;
}

3
src/MainWindow.h
View file

@ -45,9 +45,6 @@ public:
}
bool eventFilter(QObject *obj, QEvent *event) override;
private:
QSet<QWindow *> m_postedWindows;
};
class MainWindow : public QQuickView