d3v1l/matrixion
1
0
Fork 0
mirror of https://github.com/Nheko-Reborn/nheko.git synced 2024-11-22 19:08:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Work around multiple destructor calls after consteval construction in full expression

Browse source 
I have no idea, if this is our fault or not, but Jason traced it back to
the consteval on the {fmt} format string constructor.

Specifically when a consteval constructor call happens in the statement,
the destructor call is moved to the end of the block. Inside the switch
statement that means, the destructor is called multiple times, which
corrupts the use count and crashes Nheko because of a double free.

I am assuming this is a bug in clang, but this will need to be
investigated more.

fixes #1292
This commit is contained in:
Nicolas Werner 2023-01-21 20:36:17 +01:00
parent b4c0581948
commit 4c34f4bfee
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/Logging.cpp
View file

@ -45,19 +45,19 @@ qmlMessageHandler(QtMsgType type, const QMessageLogContext &context, const QStri
switch (type) { switch (type) {
case QtDebugMsg: case QtDebugMsg:
nhlog::qml()->debug("{} ({}:{}, {})", localMsg, file, context.line, function); qml_logger->debug("{} ({}:{}, {})", localMsg, file, context.line, function);
break; break;
case QtInfoMsg: case QtInfoMsg:
nhlog::qml()->info("{} ({}:{}, {})", localMsg, file, context.line, function); qml_logger->info("{} ({}:{}, {})", localMsg, file, context.line, function);
break; break;
case QtWarningMsg: case QtWarningMsg:
nhlog::qml()->warn("{} ({}:{}, {})", localMsg, file, context.line, function); qml_logger->warn("{} ({}:{}, {})", localMsg, file, context.line, function);
break; break;
case QtCriticalMsg: case QtCriticalMsg:
nhlog::qml()->critical("{} ({}:{}, {})", localMsg, file, context.line, function); qml_logger->critical("{} ({}:{}, {})", localMsg, file, context.line, function);
break; break;
case QtFatalMsg: case QtFatalMsg:
nhlog::qml()->critical("{} ({}:{}, {})", localMsg, file, context.line, function); qml_logger->critical("{} ({}:{}, {})", localMsg, file, context.line, function);
break; break;
} }
} }