From 80a39cca177a227e40806e350e7ffbb81adbca88 Mon Sep 17 00:00:00 2001 From: Nicolas Werner Date: Tue, 8 Oct 2024 23:49:29 +0200 Subject: [PATCH] Disable http3 support by default and warn if users enable it --- src/MatrixClient.cpp | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/MatrixClient.cpp b/src/MatrixClient.cpp index 05ec6a92..d3141efd 100644 --- a/src/MatrixClient.cpp +++ b/src/MatrixClient.cpp @@ -13,6 +13,9 @@ #include +#include "Logging.h" +#include "UserSettingsPage.h" + namespace http { mtx::http::Client * @@ -20,9 +23,15 @@ client() { static auto client_ = [] { auto c = std::make_shared(); - c->alt_svc_cache_path((QStandardPaths::writableLocation(QStandardPaths::CacheLocation) + - "/curl_alt_svc_cache.txt") - .toStdString()); + + // Disabled by default until CPU usage and reliability improves + if (UserSettings::instance()->qsettings()->value("enable_http3").toBool()) { + nhlog::net()->warn("Enabling http3 support. This is currently usually a worse " + "experience, so you are on your own."); + c->alt_svc_cache_path((QStandardPaths::writableLocation(QStandardPaths::CacheLocation) + + "/curl_alt_svc_cache.txt") + .toStdString()); + } return c; }(); return client_.get();