Merge pull request #1013 from tastytea/smaller-thumbnails

Don't send thumbnails that are larger than the original
This commit is contained in:
DeepBlueV7.X 2022-03-24 20:56:54 +01:00 committed by GitHub
commit 83738a61b6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -896,11 +896,18 @@ MediaUpload::startUpload()
QByteArray ba; QByteArray ba;
QBuffer buffer(&ba); QBuffer buffer(&ba);
buffer.open(QIODevice::WriteOnly); buffer.open(QIODevice::WriteOnly);
thumbnail_.save(&buffer, "PNG"); thumbnail_.save(&buffer, "PNG", 0);
if (ba.size() >= (data.size() - data.size() / 10)) {
nhlog::ui()->info(
"Thumbnail is not a lot smaller than original image, not uploading it");
nhlog::ui()->debug(
"\n Image size: {:9d}\nThumbnail size: {:9d}", data.size(), ba.size());
} else {
auto payload = std::string(ba.data(), ba.size()); auto payload = std::string(ba.data(), ba.size());
if (encrypt_) { if (encrypt_) {
mtx::crypto::BinaryBuf buf; mtx::crypto::BinaryBuf buf;
std::tie(buf, thumbnailEncryptedFile) = mtx::crypto::encrypt_file(std::move(payload)); std::tie(buf, thumbnailEncryptedFile) =
mtx::crypto::encrypt_file(std::move(payload));
payload = mtx::crypto::to_string(buf); payload = mtx::crypto::to_string(buf);
} }
thumbnailSize_ = payload.size(); thumbnailSize_ = payload.size();
@ -930,6 +937,7 @@ MediaUpload::startUpload()
}); });
return; return;
} }
}
auto payload = std::string(data.data(), data.size()); auto payload = std::string(data.data(), data.size());
if (encrypt_) { if (encrypt_) {