d3v1l/matrixion
1
0
Fork 0
mirror of https://github.com/Nheko-Reborn/nheko.git synced 2024-11-24 12:08:50 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Disable optimistic pagination to fetch events edited into the thread before the threadroot

Browse source 
fixes #1661
This commit is contained in:
Nicolas Werner 2024-01-16 04:01:13 +01:00
parent 51236c3260
commit 8ca0f61cad
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/timeline/TimelineFilter.cpp
View file

@ -123,7 +123,16 @@ TimelineFilter::fetchAgain()
return;
if (auto s = source(); s && incrementalSearchIndex == std::numeric_limits<int>::max()) {
if (this->rowCount() == cachedCount && s->canFetchMore(QModelIndex()))
if (this->rowCount() == cachedCount && s->canFetchMore(QModelIndex()) &&
// If we already have the event id of the thread in the timeline and we are filtering by
// thread, we can stop fetching more messages In theory an event could have been edited
// earlier in the timeline into the thread. So in theory this check is insufficient and
// we should instead verify that all events referring to this thread are in the timeline
// instead of just the thread root, but only Nheko supports that atm and the check would
// be expensive.
// TODO(Nico): check that all thread referrencing events are in the timeline by also
// checking all edits inside the thread.
(threadId.isEmpty() || s->idToIndex(threadId) == -1))
s->fetchMore(QModelIndex());
else
cachedCount = this->rowCount();