Lint

include/RoomSettings.h

@@ -35,10 +35,7 @@ public:
                         settings.setValue(path_, isNotificationsEnabled_);
         };
 
-        bool isNotificationsEnabled()
+        bool isNotificationsEnabled() { return isNotificationsEnabled_; };
-        {
-                return isNotificationsEnabled_;
-        };
 
         void toggleNotifications()
         {

include/ui/LoadingIndicator.h

@@ -19,23 +19,11 @@ public:
         void start();
         void stop();
 
-        QColor color()
+        QColor color() { return color_; }
-        {
+        void setColor(QColor color) { color_ = color; }
-                return color_;
-        }
-        void setColor(QColor color)
-        {
-                color_ = color;
-        }
 
-        int interval()
+        int interval() { return interval_; }
-        {
+        void setInterval(int interval) { interval_ = interval; }
-                return interval_;
-        }
-        void setInterval(int interval)
-        {
-                interval_ = interval;
-        }
 
 private slots:
         void onTimeout();

src/ChatPage.cc

@@ -32,6 +32,7 @@
 #include "StateEvent.h"
 
 constexpr int MAX_INITIAL_SYNC_FAILURES = 5;
+constexpr int SYNC_RETRY_TIMEOUT        = 10000;
 
 namespace events = matrix::events;
 
@@ -347,7 +348,7 @@ ChatPage::syncFailed(const QString &msg)
                 return;
 
         qWarning() << "Sync error:" << msg;
-        client_->sync();
+        QTimer::singleShot(SYNC_RETRY_TIMEOUT, this, [=]() { client_->sync(); });
 }
 
 // TODO: Should be moved in another class that manages this global list.

src/EmojiItemDelegate.cc

@@ -26,10 +26,7 @@ EmojiItemDelegate::EmojiItemDelegate(QObject *parent)
         data_ = new Emoji;
 }
 
-EmojiItemDelegate::~EmojiItemDelegate()
+EmojiItemDelegate::~EmojiItemDelegate() { delete data_; }
-{
-        delete data_;
-}
 
 void
 EmojiItemDelegate::paint(QPainter *painter,

src/ui/ThemeManager.cc

@@ -2,10 +2,7 @@
 
 #include "ThemeManager.h"
 
-ThemeManager::ThemeManager()
+ThemeManager::ThemeManager() { setTheme(new Theme); }
-{
-        setTheme(new Theme);
-}
 
 void
 ThemeManager::setTheme(Theme *theme)