d3v1l/matrixion
1
0
Fork 0
mirror of https://github.com/Nheko-Reborn/nheko.git synced 2024-11-22 19:08:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Disallow displaynames with only spaces or control characters

Browse source
This commit is contained in:
Nicolas Werner 2021-11-14 17:37:19 +01:00
parent 38e3498978
commit d26fe37010
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/Cache.cpp
View file

@ -3828,17 +3828,24 @@ Cache::getMembersWithKeys(const std::string &room_id, bool verified_only)
QString QString
Cache::displayName(const QString &room_id, const QString &user_id) Cache::displayName(const QString &room_id, const QString &user_id)
{ {
if (auto info = getMember(room_id.toStdString(), user_id.toStdString()); return QString::fromStdString(displayName(room_id.toStdString(), user_id.toStdString()));
info && !info->name.empty()) }
return QString::fromStdString(info->name);
return user_id; static bool
isDisplaynameSafe(const std::string &s)
{
for (QChar c : QString::fromStdString(s).toUcs4()) {
if (c.isPrint() && !c.isSpace())
return false;
}
return true;
} }
std::string std::string
Cache::displayName(const std::string &room_id, const std::string &user_id) Cache::displayName(const std::string &room_id, const std::string &user_id)
{ {
if (auto info = getMember(room_id, user_id); info && !info->name.empty()) if (auto info = getMember(room_id, user_id); info && !isDisplaynameSafe(info->name))
return info->name; return info->name;
return user_id; return user_id;