Close cursor we don't need and where we overwrite the contents

This commit is contained in:
Nicolas Werner 2020-07-18 22:59:03 +02:00
parent 8261446f83
commit d467568a65

View file

@ -2334,15 +2334,19 @@ Cache::saveOldMessages(const std::string &room_id, const mtx::responses::Message
lmdb::val indexVal, val; lmdb::val indexVal, val;
uint64_t index = std::numeric_limits<uint64_t>::max() / 2; uint64_t index = std::numeric_limits<uint64_t>::max() / 2;
auto cursor = lmdb::cursor::open(txn, orderDb); {
if (cursor.get(indexVal, val, MDB_FIRST)) { auto cursor = lmdb::cursor::open(txn, orderDb);
index = *indexVal.data<uint64_t>(); if (cursor.get(indexVal, val, MDB_FIRST)) {
index = *indexVal.data<uint64_t>();
}
} }
uint64_t msgIndex = std::numeric_limits<uint64_t>::max() / 2; uint64_t msgIndex = std::numeric_limits<uint64_t>::max() / 2;
auto msgCursor = lmdb::cursor::open(txn, order2msgDb); {
if (msgCursor.get(indexVal, val, MDB_FIRST)) { auto msgCursor = lmdb::cursor::open(txn, order2msgDb);
msgIndex = *indexVal.data<uint64_t>(); if (msgCursor.get(indexVal, val, MDB_FIRST)) {
msgIndex = *indexVal.data<uint64_t>();
}
} }
if (res.chunk.empty()) if (res.chunk.empty())
@ -2389,8 +2393,7 @@ Cache::saveOldMessages(const std::string &room_id, const mtx::responses::Message
json orderEntry = json::object(); json orderEntry = json::object();
orderEntry["event_id"] = event_id_val; orderEntry["event_id"] = event_id_val;
orderEntry["prev_batch"] = res.end; orderEntry["prev_batch"] = res.end;
lmdb::cursor_put( lmdb::dbi_put(txn, orderDb, lmdb::val(&index, sizeof(index)), lmdb::val(orderEntry.dump()));
cursor.handle(), lmdb::val(&index, sizeof(index)), lmdb::val(orderEntry.dump()));
nhlog::db()->debug("saving '{}'", orderEntry.dump()); nhlog::db()->debug("saving '{}'", orderEntry.dump());
txn.commit(); txn.commit();