d3v1l/matrixion
1
0
Fork 0
mirror of https://github.com/Nheko-Reborn/nheko.git synced 2024-11-22 19:08:58 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix a few embarrassing bugs with device list updates

Browse source
This commit is contained in:
Nicolas Werner 2021-07-06 11:39:29 +02:00
parent 9540d704e0
commit f23fd5f822
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9
1 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/Cache.cpp
View file

@ -3588,25 +3588,31 @@ Cache::updateUserKeys(const std::string &sync_token, const mtx::responses::Query
updateToWrite.self_signing_keys = update.self_signing_keys; updateToWrite.self_signing_keys = update.self_signing_keys;
updateToWrite.user_signing_keys = update.user_signing_keys; updateToWrite.user_signing_keys = update.user_signing_keys;
// If we have keys for the device already, only update the signatures. auto oldDeviceKeys = std::move(updateToWrite.device_keys);
updateToWrite.device_keys.clear();
// Don't insert keys, which we have seen once already
for (const auto &[device_id, device_keys] : update.device_keys) { for (const auto &[device_id, device_keys] : update.device_keys) {
if (updateToWrite.device_keys.count(device_id) && if (oldDeviceKeys.count(device_id) &&
updateToWrite.device_keys.at(device_id).keys == oldDeviceKeys.at(device_id).keys == device_keys.keys) {
device_keys.keys) { // this is safe, since the keys are the same
updateToWrite.device_keys.at(device_id).signatures = updateToWrite.device_keys[device_id] = device_keys;
device_keys.signatures;
} else { } else {
bool keyReused = false; bool keyReused = false;
for (const auto &[key_id, key] : device_keys.keys) { for (const auto &[key_id, key] : device_keys.keys) {
(void)key_id; (void)key_id;
if (updateToWrite.seen_device_keys.count(key)) { if (updateToWrite.seen_device_keys.count(key)) {
nhlog::crypto()->warn(
"Key '{}' reused by ({}: {})",
key,
user,
device_id);
keyReused = true; keyReused = true;
break; break;
} }
} }
if (!updateToWrite.device_keys.count(device_id) && if (!keyReused && !oldDeviceKeys.count(device_id))
!keyReused)
updateToWrite.device_keys[device_id] = device_keys; updateToWrite.device_keys[device_id] = device_keys;
} }