fix(fe/settings): add validations for bg settings

src/client/web/src/components/pane_admin.tsx

@@ -604,10 +604,12 @@ export class BgCfg extends React.Component<BgProps, BgState, {}> {
     updater().setClientCfg({ ...this.props.ui, siteName: ev.target.value });
     this.props.update(updater().updateUI);
   };
+
   changeSiteDesc = (ev: React.ChangeEvent<HTMLInputElement>) => {
     updater().setClientCfg({ ...this.props.ui, siteDesc: ev.target.value });
     this.props.update(updater().updateUI);
   };
+
   changeBgUrl = (ev: React.ChangeEvent<HTMLInputElement>) => {
     updater().setClientCfg({
       ...this.props.ui,
@@ -615,6 +617,7 @@ export class BgCfg extends React.Component<BgProps, BgState, {}> {
     });
     this.props.update(updater().updateUI);
   };
+
   changeBgRepeat = (ev: React.ChangeEvent<HTMLInputElement>) => {
     updater().setClientCfg({
       ...this.props.ui,
@@ -622,6 +625,7 @@ export class BgCfg extends React.Component<BgProps, BgState, {}> {
     });
     this.props.update(updater().updateUI);
   };
+
   changeBgPos = (ev: React.ChangeEvent<HTMLInputElement>) => {
     updater().setClientCfg({
       ...this.props.ui,
@@ -629,6 +633,7 @@ export class BgCfg extends React.Component<BgProps, BgState, {}> {
     });
     this.props.update(updater().updateUI);
   };
+
   changeBgAlign = (ev: React.ChangeEvent<HTMLInputElement>) => {
     updater().setClientCfg({
       ...this.props.ui,
@@ -642,11 +647,56 @@ export class BgCfg extends React.Component<BgProps, BgState, {}> {
   }
 
   setClientCfg = async () => {
-    return updater().setClientCfgRemote({
+    const bgURL = this.props.ui.bg.url;
-      siteName: this.props.ui.siteName,
+    if (bgURL.length === 0 || bgURL.length >= 4096) {
-      siteDesc: this.props.ui.siteDesc,
+      alertMsg(this.props.msg.pkg.get("bg.url.alert"));
-      bg: this.props.ui.bg,
+      return;
-    });
+    }
+
+    const bgRepeat = this.props.ui.bg.repeat;
+    if (
+      bgRepeat !== "repeat-x" &&
+      bgRepeat !== "repeat-y" &&
+      bgRepeat !== "repeat" &&
+      bgRepeat !== "space" &&
+      bgRepeat !== "round" &&
+      bgRepeat !== "no-repeat"
+    ) {
+      alertMsg(this.props.msg.pkg.get("bg.repeat.alert"));
+      return;
+    }
+
+    const bgPos = this.props.ui.bg.position;
+    if (
+      bgPos !== "top" &&
+      bgPos !== "bottom" &&
+      bgPos !== "left" &&
+      bgPos !== "right" &&
+      bgPos !== "center"
+    ) {
+      alertMsg(this.props.msg.pkg.get("bg.pos.alert"));
+      return;
+    }
+
+    const bgAlign = this.props.ui.bg.align;
+    if (bgAlign != "scroll" && bgAlign != "fixed" && bgAlign != "local") {
+      alertMsg(this.props.msg.pkg.get("bg.align.alert"));
+      return;
+    }
+
+    return updater()
+      .setClientCfgRemote({
+        siteName: this.props.ui.siteName,
+        siteDesc: this.props.ui.siteDesc,
+        bg: this.props.ui.bg,
+      })
+      .then((code: number) => {
+        if (code === 200) {
+          alertMsg(this.props.msg.pkg.get("update.ok"));
+        } else {
+          alertMsg(this.props.msg.pkg.get("update.fail"));
+        }
+      });
   };
 
   resetClientCfg = () => {
@@ -657,8 +707,8 @@ export class BgCfg extends React.Component<BgProps, BgState, {}> {
       bg: {
         url: "/static/img/textured_paper.png",
         repeat: "repeat",
-        position: "fixed",
+        position: "center",
-        align: "center",
+        align: "fixed",
       },
     });
     this.props.update(updater().updateUI);
@@ -697,6 +747,7 @@ export class BgCfg extends React.Component<BgProps, BgState, {}> {
                 onChange={this.changeBgUrl}
                 value={this.props.ui.bg.url}
                 className="black0-font"
+                style={{ width: "20rem" }}
                 placeholder={this.props.msg.pkg.get("cfg.bg.url")}
               />
             </div>,

src/client/web/src/i18n/en_US.ts

@@ -95,4 +95,8 @@ export const msgs: Map<string, string> = Map({
   "cfg.bg.pos": "Position",
   "cfg.bg.align": "Align",
   reset: "Reset",
+  "bg.url.alert": "Image URL is too short or too long",
+  "bg.pos.alert": "Position only supports: top, bottom, left, right, center",
+  "bg.repeat.alert": "Repeat only supports: repeat-x, repeat-y, repeat, space, round, no-repeat",
+  "bg.align.alert": "Align only supports: scroll, fixed, local",
 });

src/client/web/src/i18n/zh_CN.ts

@@ -94,4 +94,9 @@ export const msgs: Map<string, string> = Map({
   "cfg.bg.pos": "位置",
   "cfg.bg.align": "对齐",
   reset: "重置",
+  "bg.url.alert": "图片链接太短或太长",
+  "bg.pos.alert": "Position目前仅支持top, bottom, left, right, center",
+  "bg.repeat.alert":
+    "Repeat目前仅支持repeat-x, repeat-y, repeat, space, round, no-repeat",
+  "bg.align.alert": "Align目前仅支持scroll, fixed, local",
 });