From 6bd53436738bb9b0b65123d8f264903642643ccf Mon Sep 17 00:00:00 2001
From: hexxa <hexxa@outlook.com>
Date: Sun, 27 Feb 2022 10:50:14 +0800
Subject: [PATCH] fix(fe/panels): remove redundant code

---
 .../web/src/components/pane_settings.tsx      |  2 -
 src/client/web/src/components/panel_files.tsx |  6 --
 .../web/src/components/panel_sharings.tsx     | 95 +++++++++----------
 .../web/src/components/panel_uploadings.tsx   | 13 +--
 4 files changed, 45 insertions(+), 71 deletions(-)

diff --git a/src/client/web/src/components/pane_settings.tsx b/src/client/web/src/components/pane_settings.tsx
index 1ddaaa0..ea20e47 100644
--- a/src/client/web/src/components/pane_settings.tsx
+++ b/src/client/web/src/components/pane_settings.tsx
@@ -180,8 +180,6 @@ export class PaneSettings extends React.Component<Props, State, {}> {
             <div className="hr"></div>
           </div>
         );
-        // const val = clientErr;
-        // const sortVals = List<string>([]);
 
         errRows = errRows.push(elem);
       });
diff --git a/src/client/web/src/components/panel_files.tsx b/src/client/web/src/components/panel_files.tsx
index 5514739..fb16b6a 100644
--- a/src/client/web/src/components/panel_files.tsx
+++ b/src/client/web/src/components/panel_files.tsx
@@ -751,13 +751,7 @@ export class FilesPanel extends React.Component<Props, State, {}> {
         </div>
       );
 
-      // const sortVals = List<string>([item.isDir ? "d" : "f", itemPath]);
       return elem;
-      // return {
-      //   elem,
-      //   sortVals,
-      //   val: item,
-      // };
     });
 
     return <Rows rows={List(rows)} />;
diff --git a/src/client/web/src/components/panel_sharings.tsx b/src/client/web/src/components/panel_sharings.tsx
index 03bf2a9..7e2317e 100644
--- a/src/client/web/src/components/panel_sharings.tsx
+++ b/src/client/web/src/components/panel_sharings.tsx
@@ -13,7 +13,7 @@ import { ICoreState, MsgProps, UIProps } from "./core_state";
 import { LoginProps } from "./pane_login";
 import { Flexbox } from "./layout/flexbox";
 import { Container } from "./layout/container";
-import { Rows, Row } from "./layout/rows";
+import { Rows } from "./layout/rows";
 import { shareIDQuery } from "../client/files";
 import { loadingCtrl, ctrlOn, ctrlOff } from "../common/controls";
 import { CronTable } from "../common/cron";
@@ -90,56 +90,53 @@ export class SharingsPanel extends React.Component<Props, State, {}> {
   };
 
   makeRows = (sharings: Map<string, string>): List<React.ReactNode> => {
-    const sharingRows = sharings.keySeq().map((dirPath: string):React.ReactNode => {
-      const shareID = sharings.get(dirPath);
-      const sharingURL = `${
-        document.location.href.split("?")[0]
-      }?${shareIDQuery}=${shareID}`;
+    const sharingRows = sharings
+      .keySeq()
+      .map((dirPath: string): React.ReactNode => {
+        const shareID = sharings.get(dirPath);
+        const sharingURL = `${
+          document.location.href.split("?")[0]
+        }?${shareIDQuery}=${shareID}`;
 
-      const row1 = (
-        <div>
-          <div className="info">{dirPath}</div>
+        const row1 = (
+          <div>
+            <div className="info">{dirPath}</div>
 
-          <div className="op">
-            <Flexbox
-              children={List([
-                <span className="margin-r-m">
-                  <QRCodeIcon value={sharingURL} size={128} pos={false} />
-                </span>,
+            <div className="op">
+              <Flexbox
+                children={List([
+                  <span className="margin-r-m">
+                    <QRCodeIcon value={sharingURL} size={128} pos={false} />
+                  </span>,
 
-                <button
-                  onClick={() => {
-                    this.deleteSharing(dirPath);
-                  }}
-                >
-                  {this.props.msg.pkg.get("op.cancel")}
-                </button>,
-              ])}
-              childrenStyles={List([
-                { flex: "0 0 auto" },
-                { flex: "0 0 auto" },
-              ])}
-              style={{ justifyContent: "flex-end" }}
-            />
+                  <button
+                    onClick={() => {
+                      this.deleteSharing(dirPath);
+                    }}
+                  >
+                    {this.props.msg.pkg.get("op.cancel")}
+                  </button>,
+                ])}
+                childrenStyles={List([
+                  { flex: "0 0 auto" },
+                  { flex: "0 0 auto" },
+                ])}
+                style={{ justifyContent: "flex-end" }}
+              />
+            </div>
           </div>
-        </div>
-      );
+        );
 
-      const elem = (
-        <div className="sharing-item" key={dirPath}>
-          {row1}
-          <div className="desc">{sharingURL}</div>
-          <div className="hr"></div>
-        </div>
-      );
+        const elem = (
+          <div className="sharing-item" key={dirPath}>
+            {row1}
+            <div className="desc">{sharingURL}</div>
+            <div className="hr"></div>
+          </div>
+        );
 
-      return elem;
-      // return {
-      //   elem,
-      //   sortVals: List([dirPath]),
-      //   val: dirPath,
-      // };
-    });
+        return elem;
+      });
 
     return sharingRows.toList();
   };
@@ -175,13 +172,7 @@ export class SharingsPanel extends React.Component<Props, State, {}> {
     );
 
     const sharingRows = this.makeRows(this.props.sharingsInfo.sharings);
-    const view = (
-      <Rows
-        rows={sharingRows}
-        // sortKeys={List([this.props.msg.pkg.get("item.path")])}
-        // updateRows={this.updateSharings}
-      />
-    );
+    const view = <Rows rows={sharingRows} />;
     const noSharingView = (
       <Container>
         <Flexbox
diff --git a/src/client/web/src/components/panel_uploadings.tsx b/src/client/web/src/components/panel_uploadings.tsx
index 2495868..56ef394 100644
--- a/src/client/web/src/components/panel_uploadings.tsx
+++ b/src/client/web/src/components/panel_uploadings.tsx
@@ -14,7 +14,7 @@ import { LoginProps } from "./pane_login";
 import { UploadEntry, UploadState } from "../worker/interface";
 import { Flexbox } from "./layout/flexbox";
 import { Container } from "./layout/container";
-import { Rows, Row } from "./layout/rows";
+import { Rows } from "./layout/rows";
 import { loadingCtrl, ctrlOn, ctrlOff } from "../common/controls";
 import { HotkeyHandler } from "../common/hotkeys";
 
@@ -173,8 +173,6 @@ export class UploadingsPanel extends React.Component<Props, State, {}> {
         </div>
       );
 
-      // file path
-      // const sortVals = List<string>([uploading.filePath]);
       return elem;
     });
   };
@@ -207,14 +205,7 @@ export class UploadingsPanel extends React.Component<Props, State, {}> {
     const uploadingRows = this.makeRowsInputs(
       this.props.uploadingsInfo.uploadings
     );
-    // const sortKeys = List([this.props.msg.pkg.get("item.path")]);
-    const view = (
-      <Rows
-        // sortKeys={sortKeys}
-        rows={uploadingRows}
-        // updateRows={this.updateUploadings}
-      />
-    );
+    const view = <Rows rows={uploadingRows} />;
 
     const noUploadingView = (
       <Container>