Fix append (#43)

* fix(fs/local): remove O_APPEND for write_at

* fix(files): clean download api

* chore(workflows): add manual dispatch for docker

* test(files): close fd in the progress of uploading
This commit is contained in:
Hexxa 2021-03-19 23:00:22 +08:00 committed by GitHub
parent 9b2157ac6a
commit a9ccb4506c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 61 additions and 11 deletions

View file

@ -446,4 +446,59 @@ func TestFileHandlers(t *testing.T) {
t.Fatalf("info is not deleted, info len(%d)", len(lResp.UploadInfos))
}
})
t.Run("test uploading APIs: Create, Stop, UploadChunk)", func(t *testing.T) {
cl := client.NewFilesClient(addr)
files := map[string]string{
"uploadings/path1/f1": "12345678",
}
for filePath, content := range files {
fileSize := int64(len([]byte(content)))
res, _, errs := cl.Create(filePath, fileSize)
if len(errs) > 0 {
t.Fatal(errs)
} else if res.StatusCode != 200 {
t.Fatal(res.StatusCode)
}
chunks := [][]byte{
[]byte(content)[:fileSize/2],
[]byte(content)[fileSize/2:],
}
offset := int64(0)
for _, chunk := range chunks {
base64Content := base64.StdEncoding.EncodeToString(chunk)
res, _, errs = cl.UploadChunk(filePath, base64Content, offset)
offset += int64(len(chunk))
if len(errs) > 0 {
t.Fatal(errs)
} else if res.StatusCode != 200 {
t.Fatal(res.StatusCode)
}
err = fs.Close()
if err != nil {
t.Fatal(err)
}
}
err = fs.Sync()
if err != nil {
t.Fatal(err)
}
// metadata
_, mRes, errs := cl.Metadata(filePath)
if len(errs) > 0 {
t.Fatal(errs)
} else if mRes.Size != fileSize {
t.Fatal("incorrect uploaded size", mRes)
}
assetDownloadOK(t, filePath, content)
}
})
}