Disable http3 support by default and warn if users enable it

This commit is contained in:
Nicolas Werner 2024-10-08 23:49:29 +02:00
parent 5523460f4e
commit 80a39cca17
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9

View file

@ -13,6 +13,9 @@
#include <mtx/responses.hpp> #include <mtx/responses.hpp>
#include "Logging.h"
#include "UserSettingsPage.h"
namespace http { namespace http {
mtx::http::Client * mtx::http::Client *
@ -20,9 +23,15 @@ client()
{ {
static auto client_ = [] { static auto client_ = [] {
auto c = std::make_shared<mtx::http::Client>(); auto c = std::make_shared<mtx::http::Client>();
c->alt_svc_cache_path((QStandardPaths::writableLocation(QStandardPaths::CacheLocation) +
"/curl_alt_svc_cache.txt") // Disabled by default until CPU usage and reliability improves
.toStdString()); if (UserSettings::instance()->qsettings()->value("enable_http3").toBool()) {
nhlog::net()->warn("Enabling http3 support. This is currently usually a worse "
"experience, so you are on your own.");
c->alt_svc_cache_path((QStandardPaths::writableLocation(QStandardPaths::CacheLocation) +
"/curl_alt_svc_cache.txt")
.toStdString());
}
return c; return c;
}(); }();
return client_.get(); return client_.get();